add FixKw, a companion to Fix{N}
#55711
Open
+48
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this extend Fix instead of having a new struct? E.g if we consider the senario of fixing kwargs it's also possible to fix some args and some kwargs. |
|
That's of course debatable. However, if one wants to fix two positional arguments, then there is also no functionality at present to combine them. |
nsajko
added
feature
|
Are you interested in moving forward with this? I think that there should be some functionality to fix keyword arguments, be it this proposal or some other solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword arguments are mentioned several times in the discussion of the recent
Fix{N}PR #54653. However, support for them was dropped in the end. I don't know if that was to keepFix{N}simple or for more fundamental reasons. I would like to proposeFixKwas a way to do for keyword arguments whatFix{N}does for positional arguments. I think it should exist for the sake of completeness. It is also helpful becausemap,reduceand the like don't allow to pass keyword arguments to the function one uses.I've chosen the name
FixKwto resembleFixalthough the "fixed" keyword arguments can still be overridden. I'm open to other names.Please let me know what you think. If you like it, I can add tests and update
NEWS.md.